Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __future__ import. #579

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Remove __future__ import. #579

merged 1 commit into from
Mar 24, 2025

Conversation

purple4reina
Copy link
Contributor

@purple4reina purple4reina commented Mar 20, 2025

What does this PR do?

Removes __future__ import.

Motivation

It is not needed anymore.

Testing Guidelines

I ran a before/after comparison. We see there's actually a very very slight cold start gain when removing the import.

Screenshot 2025-03-20 at 11 59 06 AM

Additional Notes

The __future__ imports allow you to optionally apply a new python feature which will be required in a future python version.

Looking at this chart https://docs.python.org/3/library/__future__.html#module-contents, we see that the absolute_import feature was added to python in v3.0. We can therefore remove this import because the feature is on by default anyway.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Sorry, something went wrong.

@purple4reina purple4reina requested a review from a team as a code owner March 20, 2025 18:59
@purple4reina purple4reina merged commit 71c14e3 into main Mar 24, 2025
60 checks passed
@purple4reina purple4reina deleted the rey.abolofia/no-future branch March 24, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants