Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sam/build-python images for building layers. #577

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

Changes the base image for building layers.

Motivation

If trying to install ddtrace from source, it will build all of the c binaries. When using the currently defined base image to build ddtrace, it gives the following error when executing the lambda function:

[ERROR] Runtime.ImportModuleError: Unable to import module 'datadog_lambda.handler': /lib64/libstdc++.so.6: version 'GLIBCXX_3.4.30' not found (required by /opt/python/lib/python3.12/site-packages/ddtrace/internal/_threads.cpython-312-aarch64-linux-gnu.so)

We are guaranteed that the glibc versions will properly match between the sam/build-python images and the lambda/python image.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Sorry, something went wrong.

@purple4reina purple4reina requested a review from a team as a code owner March 17, 2025 20:11
@purple4reina purple4reina merged commit 5a55fe4 into main Mar 17, 2025
60 checks passed
@purple4reina purple4reina deleted the rey.abolofia/build-ddtrace branch March 17, 2025 20:16
brettlangdon added a commit that referenced this pull request Mar 27, 2025
This reverts commit 5a55fe4.
duncanista pushed a commit that referenced this pull request Mar 27, 2025
This reverts commit 5a55fe4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants