Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Send the cgroup manager in activity dumps #33126

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Jan 20, 2025

What does this PR do?

Sends the cgroup runtime (containerd, systemd, ...) along with the cgroup id
for activity dumps.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@lebauce lebauce added changelog/no-changelog team/agent-security qa/rc-required Only for a PR that requires validation on the Release Candidate labels Jan 20, 2025
@lebauce lebauce requested a review from a team as a code owner January 20, 2025 14:50
@lebauce lebauce force-pushed the lebauce/ad-cgroup-runtime branch from 7d34e91 to 7b9e213 Compare January 20, 2025 15:18
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 20, 2025

Uncompressed package size comparison

Comparison with ancestor 1feb84b482c89319257177625316d303e43286c3

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.02MB ⚠️ 940.41MB 940.40MB 0.50MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 940.41MB 940.40MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 930.67MB 930.66MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 917.32MB 917.31MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 927.04MB 927.03MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 94.04MB 94.04MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 94.04MB 94.04MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.88MB 58.88MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.39MB 56.39MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.89MB 477.89MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.97MB 93.97MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 90.02MB 90.02MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.09MB 90.09MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 20, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53849947 --os-family=ubuntu

Note: This applies to commit 4c1149e

@lebauce lebauce force-pushed the lebauce/ad-cgroup-runtime branch 2 times, most recently from c9ec072 to aef7ccf Compare January 22, 2025 15:39
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels Jan 22, 2025
Copy link

cit-pr-commenter bot commented Jan 22, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: be96f4bf-a7fa-477a-b1f3-6f2ca3beba51

Baseline: 1feb84b
Comparison: 4c1149e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.14 [+0.10, +0.17] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.13 [-0.82, +1.08] 1 Logs
quality_gate_idle_all_features memory utilization +0.08 [+0.04, +0.12] 1 Logs bounds checks dashboard
file_tree memory utilization +0.08 [+0.02, +0.14] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.81, +0.91] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.28] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.68, +0.69] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.93, +0.93] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.80, +0.77] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.14 [-0.91, +0.62] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.32 [-0.79, +0.14] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.44, -0.30] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.01 [-1.90, -0.12] 1 Logs
quality_gate_logs % cpu utilization -2.29 [-5.29, +0.71] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@lebauce lebauce force-pushed the lebauce/ad-cgroup-runtime branch 5 times, most recently from ab73028 to 1c8110f Compare January 23, 2025 16:15
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 23, 2025
@lebauce lebauce force-pushed the lebauce/ad-cgroup-runtime branch from 1c8110f to feb2034 Compare January 23, 2025 19:29
@lebauce
Copy link
Contributor Author

lebauce commented Jan 23, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-23 19:29:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-23 19:39:32 UTC ⚠️ MergeQueue: This merge request was unqueued

sylvain.baubeau@datadoghq.com unqueued this merge request

@lebauce
Copy link
Contributor Author

lebauce commented Jan 23, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-23 19:39:32 UTC ℹ️ Devflow: /remove

Verified

This commit was signed with the committer’s verified signature.
lebauce Sylvain Baubeau
@lebauce lebauce force-pushed the lebauce/ad-cgroup-runtime branch from feb2034 to 4c1149e Compare January 23, 2025 19:42
@lebauce
Copy link
Contributor Author

lebauce commented Jan 23, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-23 19:57:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-23 21:07:10 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.


2025-01-23 21:52:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c418b43 into main Jan 23, 2025
411 of 419 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lebauce/ad-cgroup-runtime branch January 23, 2025 21:52
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants