-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] Send the cgroup manager in activity dumps #33126
Conversation
7d34e91
to
7b9e213
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=53849947 --os-family=ubuntu Note: This applies to commit 4c1149e |
c9ec072
to
aef7ccf
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 1feb84b Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_idle | memory utilization | +0.14 | [+0.10, +0.17] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.13 | [-0.82, +1.08] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.08 | [+0.04, +0.12] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | +0.08 | [+0.02, +0.14] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.81, +0.91] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.27, +0.28] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.00 | [-0.68, +0.69] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.00 | [-0.93, +0.93] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.01] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.65, +0.63] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.80, +0.77] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.14 | [-0.91, +0.62] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.32 | [-0.79, +0.14] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.37 | [-0.44, -0.30] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.01 | [-1.90, -0.12] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -2.29 | [-5.29, +0.71] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
ab73028
to
1c8110f
Compare
1c8110f
to
feb2034
Compare
/merge |
Devflow running:
|
/remove |
Devflow running:
|
feb2034
to
4c1149e
Compare
/merge |
Devflow running:
|
What does this PR do?
Sends the cgroup runtime (containerd, systemd, ...) along with the cgroup id
for activity dumps.
Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes