-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argon2): add secret
parameter
#57
feat(argon2): add secret
parameter
#57
Conversation
@Daninet Should I add specific tests for the secret parameter or just integrate it in the existing ones ? |
Awesome. You can create a new test group dedicated for the secret parameter with a few test cases here: https://github.com/Daninet/hash-wasm/blob/master/test/argon2.test.ts Thank you! |
${argon2i} | ${'somesecret'} | ${64} | ${1} | ${1} | ${'$argon2i$v=19$m=64,t=1,p=1$c29tZXNhbHQ$feIpCNM774/NRKH7kk05fPDR9AVmS1Ti'} | ||
${argon2d} | ${'somesecret'} | ${64} | ${1} | ${1} | ${'$argon2d$v=19$m=64,t=1,p=1$c29tZXNhbHQ$BC1zOS/31Hbq1XqrbUolSJD8lbGO5hYA'} | ||
${argon2id} | ${'somesecret'} | ${64} | ${1} | ${1} | ${'$argon2id$v=19$m=64,t=1,p=1$c29tZXNhbHQ$RvwmOL1c3noOUb9Tb0PVAyFny0544DEN'} | ||
|
||
${argon2i} | ${'somesecret'} | ${64} | ${2} | ${1} | ${'$argon2i$v=19$m=64,t=2,p=1$c29tZXNhbHQ$TSUIZoltkBnapO9908hb/n6UtBg/NzWC'} | ||
${argon2d} | ${'somesecret'} | ${64} | ${2} | ${1} | ${'$argon2d$v=19$m=64,t=2,p=1$c29tZXNhbHQ$UwnJWSBvwsqUqSfQ3O8eAeM35RaF3qVV'} | ||
${argon2id} | ${'somesecret'} | ${64} | ${2} | ${1} | ${'$argon2id$v=19$m=64,t=2,p=1$c29tZXNhbHQ$iOtAF9uLeVkqVavTbncWiTAX+a0RQ34k'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validated the hashes against another implementation of argon2 (rust argon2 crate).
|
@Daninet friendly bump :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @malobre !
Closes #53.