Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVColParser: correctly set nil values in Rows #318

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

IvoGoman
Copy link
Contributor

@IvoGoman IvoGoman commented Aug 9, 2023

I am using a struct with a *string such as

type Result struct {
    Value    *string `json:"value,omitempty"`
}

Previously the NULL passed to FromCSVString(..) was not working correctly.
After scanning the result Rows of the query into the struct resulted in an empty string.
With this change the mock behaves like the DB and the Value field is nil

rows_test.go Outdated Show resolved Hide resolved
Co-authored-by: Jessie A. Morris <jessie@jessieamorris.com>
@vtolstov
Copy link

Does with this change I can create csv with null value for int for example? Or determine empty string or null?

@IvoGoman
Copy link
Contributor Author

Does with this change I can create csv with null value for int for example? Or determine empty string or null?

Yes, the intention of this PR is to reflect any NULL in the CSV correctly with pointer variables such *int or sql.NullInt etc.

@JessieAMorris JessieAMorris merged commit b2f0b45 into DATA-DOG:master Aug 10, 2023
@IvoGoman IvoGoman deleted the fix/nilonstringpointer branch August 10, 2023 20:49
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Dec 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock)
| require | patch | `v1.5.0` -> `v1.5.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary>

###
[`v1.5.1`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.1)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.0...v1.5.1)

Release was tested & verified using [aws-sqk
](https://togithub.com/aws/aws-xray-sdk-go/pull/450)

##### What's Changed

- Add go 1.15 in travis by
[@&#8203;gold-kou](https://togithub.com/gold-kou) in
[DATA-DOG/go-sqlmock#234
- Update code sample by
[@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) in
[DATA-DOG/go-sqlmock#244
- Fix ExpectedExec Stringer implementation by
[@&#8203;maguro](https://togithub.com/maguro) in
[DATA-DOG/go-sqlmock#249
- Add Multi Row Support by
[@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) in
[DATA-DOG/go-sqlmock#263
- Add Go 1.16 and 1.17 to Travis by
[@&#8203;gliptak](https://togithub.com/gliptak) in
[DATA-DOG/go-sqlmock#279
- fix package by [@&#8203;col3name](https://togithub.com/col3name) in
[DATA-DOG/go-sqlmock#284
- \[Chore]: Add Issue Template by
[@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) in
[DATA-DOG/go-sqlmock#289
- Fix args passed not exp by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#295
- fixes csv parse errors being silently ignored by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#315
- CSVColParser: correctly set nil values in Rows by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#318
- Modify: existing panic in AddRow to give a hint to the issue by
[@&#8203;co60ca](https://togithub.com/co60ca) in
[DATA-DOG/go-sqlmock#326

##### New Contributors

- [@&#8203;gold-kou](https://togithub.com/gold-kou) made their first
contribution in
[DATA-DOG/go-sqlmock#234
- [@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) made their
first contribution in
[DATA-DOG/go-sqlmock#244
- [@&#8203;maguro](https://togithub.com/maguro) made their first
contribution in
[DATA-DOG/go-sqlmock#249
- [@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) made
their first contribution in
[DATA-DOG/go-sqlmock#263
- [@&#8203;col3name](https://togithub.com/col3name) made their first
contribution in
[DATA-DOG/go-sqlmock#284
- [@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) made their first
contribution in
[DATA-DOG/go-sqlmock#289
- [@&#8203;IvoGoman](https://togithub.com/IvoGoman) made their first
contribution in
[DATA-DOG/go-sqlmock#295
- [@&#8203;co60ca](https://togithub.com/co60ca) made their first
contribution in
[DATA-DOG/go-sqlmock#326

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.0...v1.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-apps that referenced this pull request Feb 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock)
| `v1.5.0` -> `v1.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.0/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.0/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary>

###
[`v1.5.2`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.1...v1.5.2)

#### What's Changed

##### Fixes breaking change from:
[DATA-DOG/go-sqlmock#295

- fix: make no argument passed validation opt-in by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#329

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.1...v1.5.2

###
[`v1.5.1`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.1)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.0...v1.5.1)

Release was tested & verified using [aws-sqk
](https://togithub.com/aws/aws-xray-sdk-go/pull/450)

##### What's Changed

- Add go 1.15 in travis by
[@&#8203;gold-kou](https://togithub.com/gold-kou) in
[DATA-DOG/go-sqlmock#234
- Update code sample by
[@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) in
[DATA-DOG/go-sqlmock#244
- Fix ExpectedExec Stringer implementation by
[@&#8203;maguro](https://togithub.com/maguro) in
[DATA-DOG/go-sqlmock#249
- Add Multi Row Support by
[@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) in
[DATA-DOG/go-sqlmock#263
- Add Go 1.16 and 1.17 to Travis by
[@&#8203;gliptak](https://togithub.com/gliptak) in
[DATA-DOG/go-sqlmock#279
- fix package by [@&#8203;col3name](https://togithub.com/col3name) in
[DATA-DOG/go-sqlmock#284
- \[Chore]: Add Issue Template by
[@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) in
[DATA-DOG/go-sqlmock#289
- Fix args passed not exp by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#295
- fixes csv parse errors being silently ignored by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#315
- CSVColParser: correctly set nil values in Rows by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#318
- Modify: existing panic in AddRow to give a hint to the issue by
[@&#8203;co60ca](https://togithub.com/co60ca) in
[DATA-DOG/go-sqlmock#326

##### New Contributors

- [@&#8203;gold-kou](https://togithub.com/gold-kou) made their first
contribution in
[DATA-DOG/go-sqlmock#234
- [@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) made their
first contribution in
[DATA-DOG/go-sqlmock#244
- [@&#8203;maguro](https://togithub.com/maguro) made their first
contribution in
[DATA-DOG/go-sqlmock#249
- [@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) made
their first contribution in
[DATA-DOG/go-sqlmock#263
- [@&#8203;col3name](https://togithub.com/col3name) made their first
contribution in
[DATA-DOG/go-sqlmock#284
- [@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) made their first
contribution in
[DATA-DOG/go-sqlmock#289
- [@&#8203;IvoGoman](https://togithub.com/IvoGoman) made their first
contribution in
[DATA-DOG/go-sqlmock#295
- [@&#8203;co60ca](https://togithub.com/co60ca) made their first
contribution in
[DATA-DOG/go-sqlmock#326

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.0...v1.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/PingCAP-QE/ee-apps).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuMjAwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants