Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args passed not exp #295

Merged
merged 2 commits into from Aug 19, 2022
Merged

Conversation

IvoGoman
Copy link
Contributor

@IvoGoman IvoGoman commented Aug 1, 2022

This PR changes the behavior in the expectation matching. Previously if no query arg was expected but one was actually passed during query execution the expectations were still met. (Example https://go.dev/play/p/VwF9k6KlET2 ) With this change it is ensured that expected and actual query args do always match.

This should be considered a breaking change as it changes the behavior how expectations are matched and can result in failing unit tests.

I was not able to run the tests locally against go < 1.8. The install of multiple go version mentioned here (https://go.dev/doc/manage-install#installing-multiple) did not work. There seems to be no darwin-arm64 version hosted for 1.7.6

Resolves #292

@fatelei fatelei merged commit 44e746a into DATA-DOG:master Aug 19, 2022
@fatelei
Copy link
Collaborator

fatelei commented Aug 19, 2022

good job

@IvoGoman IvoGoman deleted the fix-args-passed-not-exp branch August 22, 2022 07:22
@jameshalsall
Copy link

This was included in a bugfix release but as the author noted it's a breaking change in behaviour.

@Gilthoniel
Copy link

Gilthoniel commented Dec 12, 2023

As @jameshalsall , this is breaking change as you may very well write tests before v1.5.1 that were not interested in the given arguments but the processing of the result for instance.

Could we have something like this to enable this behavior instead ?

_, mockDB, _ := sqlmock.New()
mockDB.MatchArgumentsStrict(true)

(thank you for the library btw!)

mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Dec 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock)
| require | patch | `v1.5.0` -> `v1.5.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary>

###
[`v1.5.1`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.1)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.0...v1.5.1)

Release was tested & verified using [aws-sqk
](https://togithub.com/aws/aws-xray-sdk-go/pull/450)

##### What's Changed

- Add go 1.15 in travis by
[@&#8203;gold-kou](https://togithub.com/gold-kou) in
[DATA-DOG/go-sqlmock#234
- Update code sample by
[@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) in
[DATA-DOG/go-sqlmock#244
- Fix ExpectedExec Stringer implementation by
[@&#8203;maguro](https://togithub.com/maguro) in
[DATA-DOG/go-sqlmock#249
- Add Multi Row Support by
[@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) in
[DATA-DOG/go-sqlmock#263
- Add Go 1.16 and 1.17 to Travis by
[@&#8203;gliptak](https://togithub.com/gliptak) in
[DATA-DOG/go-sqlmock#279
- fix package by [@&#8203;col3name](https://togithub.com/col3name) in
[DATA-DOG/go-sqlmock#284
- \[Chore]: Add Issue Template by
[@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) in
[DATA-DOG/go-sqlmock#289
- Fix args passed not exp by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#295
- fixes csv parse errors being silently ignored by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#315
- CSVColParser: correctly set nil values in Rows by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#318
- Modify: existing panic in AddRow to give a hint to the issue by
[@&#8203;co60ca](https://togithub.com/co60ca) in
[DATA-DOG/go-sqlmock#326

##### New Contributors

- [@&#8203;gold-kou](https://togithub.com/gold-kou) made their first
contribution in
[DATA-DOG/go-sqlmock#234
- [@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) made their
first contribution in
[DATA-DOG/go-sqlmock#244
- [@&#8203;maguro](https://togithub.com/maguro) made their first
contribution in
[DATA-DOG/go-sqlmock#249
- [@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) made
their first contribution in
[DATA-DOG/go-sqlmock#263
- [@&#8203;col3name](https://togithub.com/col3name) made their first
contribution in
[DATA-DOG/go-sqlmock#284
- [@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) made their first
contribution in
[DATA-DOG/go-sqlmock#289
- [@&#8203;IvoGoman](https://togithub.com/IvoGoman) made their first
contribution in
[DATA-DOG/go-sqlmock#295
- [@&#8203;co60ca](https://togithub.com/co60ca) made their first
contribution in
[DATA-DOG/go-sqlmock#326

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.0...v1.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
@IvoGoman
Copy link
Contributor Author

Opened #329 to make this stricter args checking an opt-in.

TylerHelmuth added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jan 9, 2024
…0346)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock)
| `v1.5.1` -> `v1.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary>

###
[`v1.5.2`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.1...v1.5.2)

#### What's Changed

##### Fixes breaking change from:
[DATA-DOG/go-sqlmock#295

- fix: make no argument passed validation opt-in by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#329

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.1...v1.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…en-telemetry#30346)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock)
| `v1.5.1` -> `v1.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary>

###
[`v1.5.2`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.1...v1.5.2)

#### What's Changed

##### Fixes breaking change from:
[DATA-DOG/go-sqlmock#295

- fix: make no argument passed validation opt-in by
[@&open-telemetry#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#329

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.1...v1.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-apps that referenced this pull request Feb 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock)
| `v1.5.0` -> `v1.5.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.0/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDATA-DOG%2fgo-sqlmock/v1.5.0/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary>

###
[`v1.5.2`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.2)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.1...v1.5.2)

#### What's Changed

##### Fixes breaking change from:
[DATA-DOG/go-sqlmock#295

- fix: make no argument passed validation opt-in by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#329

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.1...v1.5.2

###
[`v1.5.1`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.1)

[Compare
Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.0...v1.5.1)

Release was tested & verified using [aws-sqk
](https://togithub.com/aws/aws-xray-sdk-go/pull/450)

##### What's Changed

- Add go 1.15 in travis by
[@&#8203;gold-kou](https://togithub.com/gold-kou) in
[DATA-DOG/go-sqlmock#234
- Update code sample by
[@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) in
[DATA-DOG/go-sqlmock#244
- Fix ExpectedExec Stringer implementation by
[@&#8203;maguro](https://togithub.com/maguro) in
[DATA-DOG/go-sqlmock#249
- Add Multi Row Support by
[@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) in
[DATA-DOG/go-sqlmock#263
- Add Go 1.16 and 1.17 to Travis by
[@&#8203;gliptak](https://togithub.com/gliptak) in
[DATA-DOG/go-sqlmock#279
- fix package by [@&#8203;col3name](https://togithub.com/col3name) in
[DATA-DOG/go-sqlmock#284
- \[Chore]: Add Issue Template by
[@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) in
[DATA-DOG/go-sqlmock#289
- Fix args passed not exp by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#295
- fixes csv parse errors being silently ignored by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#315
- CSVColParser: correctly set nil values in Rows by
[@&#8203;IvoGoman](https://togithub.com/IvoGoman) in
[DATA-DOG/go-sqlmock#318
- Modify: existing panic in AddRow to give a hint to the issue by
[@&#8203;co60ca](https://togithub.com/co60ca) in
[DATA-DOG/go-sqlmock#326

##### New Contributors

- [@&#8203;gold-kou](https://togithub.com/gold-kou) made their first
contribution in
[DATA-DOG/go-sqlmock#234
- [@&#8203;ashhadsheikh](https://togithub.com/ashhadsheikh) made their
first contribution in
[DATA-DOG/go-sqlmock#244
- [@&#8203;maguro](https://togithub.com/maguro) made their first
contribution in
[DATA-DOG/go-sqlmock#249
- [@&#8203;asahasrabuddhe](https://togithub.com/asahasrabuddhe) made
their first contribution in
[DATA-DOG/go-sqlmock#263
- [@&#8203;col3name](https://togithub.com/col3name) made their first
contribution in
[DATA-DOG/go-sqlmock#284
- [@&#8203;Ghvstcode](https://togithub.com/Ghvstcode) made their first
contribution in
[DATA-DOG/go-sqlmock#289
- [@&#8203;IvoGoman](https://togithub.com/IvoGoman) made their first
contribution in
[DATA-DOG/go-sqlmock#295
- [@&#8203;co60ca](https://togithub.com/co60ca) made their first
contribution in
[DATA-DOG/go-sqlmock#326

**Full Changelog**:
DATA-DOG/go-sqlmock@v1.5.0...v1.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/PingCAP-QE/ee-apps).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuMjAwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected result of argument matcher if no args expected but args supplied
5 participants