Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tools as Components & Services #1163

Merged
merged 18 commits into from
Nov 16, 2024
Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Nov 5, 2024

  • BREAKING changes
    • Property Models.Bom.tools is an instance of Models.Tools now (#1152 via #1163)
      Before, it was an instance of Models.ToolRepository.
  • Added
    • Static function Models.Tool.fromComponent() (via #1163)
    • Static function Models.Tool.fromService() (via #1163)
    • New class Models.Tools (#1152 via #1163)
    • New serialization/normalization for Models.Tools (#1152 via #1163)
  • Changed
    • Serializers and Bom-Normalizers will take changed Models.Bom.tools into account (#1152 via #1163)

fixes #1152

as described here in #1152 (comment)

@jkowalleck jkowalleck added enhancement New feature or request breaking change labels Nov 5, 2024
Copy link

codacy-production bot commented Nov 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ccdd7f5) 24633 24241 98.41%
Head commit (cfb5d5a) 25083 (+450) 24694 (+453) 98.45% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1163) 175 175 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck changed the title feat: tools as Components & Services [WIP] feat: tools as Components & Services Nov 5, 2024
@jkowalleck jkowalleck force-pushed the feat/tools-components-services branch from a9e783c to 95fb07f Compare November 13, 2024 09:18
@jkowalleck jkowalleck changed the title [WIP] feat: tools as Components & Services feat: tools as Components & Services Nov 13, 2024
@jkowalleck jkowalleck marked this pull request as ready for review November 13, 2024 09:39
@jkowalleck jkowalleck requested a review from a team as a code owner November 13, 2024 09:39
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
cs
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the feat/tools-components-services branch from a15d4d8 to cfb5d5a Compare November 16, 2024 13:08
@jkowalleck jkowalleck merged commit 5ff1d20 into main Nov 16, 2024
42 checks passed
@jkowalleck jkowalleck deleted the feat/tools-components-services branch November 16, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support for Metadata.tools format intrduced with CDX 1.5
1 participant