Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Toolkit assemblies alike the NuGet package version #2328

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

jfversluis
Copy link
Member

Description of Change

Adds the -p:Version property to the pipeline which will apply the right version to the assemblies in the NuGets

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Sorry, something went wrong.

@jfversluis jfversluis changed the title Remove assembly version numbers from csproj Version Toolkit assemblies alike the NuGet package version Nov 8, 2024
This reverts commit 22a0055.
@TheCodeTraveler TheCodeTraveler marked this pull request as ready for review November 20, 2024 15:34
@TheCodeTraveler TheCodeTraveler merged commit 9741f1a into main Nov 20, 2024
6 of 9 checks passed
@TheCodeTraveler TheCodeTraveler deleted the fix-2299 branch November 20, 2024 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Please specify file versions for CommunityToolkit.Maui and CommunityToolkit.Maui.Core
2 participants