Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the navigation to the SelectAllText page on macOS #1402

Merged
merged 3 commits into from Sep 23, 2023

Conversation

vhugogarcia
Copy link
Contributor

Description of Change

Updated the StaticResource set for the border, since it was preventing to navigate to the SelectAllText page on macOS only. It works on iOS, Android, and Windows as well.

The documentation has been created on the following PR: MicrosoftDocs/CommunityToolkit#316

Linked Issues

PR Checklist

cc: @pictos @brminnick

Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, just make sure we renamed it in the whole project SoftFrameBackgroundColor

@brminnick brminnick enabled auto-merge (squash) September 23, 2023 20:01
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vhugogarcia! Approved

I don't see SoftFrameBackgroundColor used anywhere in the app. It was likely a legacy resource we ported from XamarinCommunityToolkit.

@brminnick brminnick merged commit 7dd409e into main Sep 23, 2023
7 checks passed
@brminnick brminnick deleted the vh/select-all-text-behavior branch September 23, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] MacCatalyst SelectAllTextBehavior on Editor
3 participants