Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github API url is not necessary #27

Closed
erodewald opened this issue Jul 15, 2021 · 3 comments
Closed

Github API url is not necessary #27

erodewald opened this issue Jul 15, 2021 · 3 comments

Comments

@erodewald
Copy link

By default, GitHub and its variants include an GITHUB_API_URL environment variable, so the addition of github_api_url just increased code complexity, reduced maintainability, and actually reduced flexibility since it assumes https://. The latter meant I was not able to simply pass in $GITHUB_API_URL, because it became an invalid url (e.g., https://https://my-enterprise.url.com/api/v3).

@cscleison
Copy link

cscleison commented Apr 19, 2022

actually, if i keep the github_api_url: 'api.github.com' that comes from the example, it does not label my prs at all. it only worked after i omitted the line. it took me quite a while to figure it out 😄

@rubeeengm
Copy link

actually, if i keep the github_api_url: 'api.github.com' that comes from the example, it does not label my prs at all. it only worked after i omitted the line. it took me quite a while to figure it out 😄

Nice!

@johnlk
Copy link
Collaborator

johnlk commented Apr 16, 2024

There were two potential issues:

  1. the readme example excluded the http:// which would break if copied
  2. github enterprise accounts have to set a value, which shouldn't be required

Both have seen been addressed by #57 and #62 respectively.

@johnlk johnlk closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants