Fix an issue attempting to re-copy the same file when the destination does not have write permissions #12253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
reviewed
Feb 5, 2024
lib/cocoapods/downloader/cache.rb
Outdated
| @@ -327,13 +327,15 @@ def copy_source_and_clean(source, destination, spec) | |||
| # @return [Void] | |||
| # | |||
| def copy_files(files, source, destination) | |||
| files = files.select { |f| File.exist?(f) } | |||
| files = files | |||
There was a problem hiding this comment.
nit. do we need to map first and then select or just select and convert to Pathname within the select?
There was a problem hiding this comment.
I guess we do because we use them below as pathnames
dnkoutso
approved these changes
Feb 5, 2024
paulb777
approved these changes
Feb 5, 2024
|
Didn't fix my ruby 3.3.0 / macOS 13.6.4 |
|
@Chaseshaw got an example I could try? |
amorde
force-pushed
the
amorde/fix-duplicate-file-copy
branch
from
129a45d
to
d47ddda
Compare
dnkoutso
approved these changes
Feb 6, 2024
… does not have write permissions
amorde
force-pushed
the
amorde/fix-duplicate-file-copy
branch
from
d47ddda
to
cab06c3
Compare
|
Going to go ahead and merge + ship since we know it fixes at least certain cases of this issue. |
|
@amorde the following Podfile is causing platform :ios, '17.0'
inhibit_all_warnings!
use_frameworks!
target 'CocoaPodsReproducer' do
pod 'Instabug', '12.6.0', :source => 'https://cdn.cocoapods.org/'
endThe error: |
|
Can confirm, I can't use 1.15.1 when 1.15.0 is fine |
|
We'll push out an update that reverts this PR as well as the original change that this PR was attempting to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12226
The underlying issue was attempting to copy a file when it already exists at the destination and does not have the write permission set, causing a write permission error.
The copy is duplicative because a previous pass had already copied a parent directory including the files. The fix is to update the logic to only copy individual files instead of also copying folders.
Note: this logic could be optimized a bit further, but I was looking for a reliable fast solution to the bug for now.