Revert 1.15.0 regression #12229
Merged
Revert 1.15.0 regression #12229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we ready to merge this ? |
Vyazovoy
reviewed
Feb 2, 2024
|
|
||
| files_by_dir.each do |dir, files_to_copy| | ||
| FileUtils.mkdir_p(dir) | ||
| FileUtils.cp_r(files_to_copy, dir) |
There was a problem hiding this comment.
Looks like the issue is that when this line copies a link and the link points to already existing file then it trow the error. cc @dnkoutso
|
Closing in favor of #12253 |
amorde
force-pushed
the
revert-1-15-regresssion
branch
from
f9edad6
to
5397ce9
Compare
amorde
force-pushed
the
revert-1-15-regresssion
branch
from
5397ce9
to
810e8cb
Compare
amorde
force-pushed
the
revert-1-15-regresssion
branch
from
810e8cb
to
af6769a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12226
It reverts #12154 and two follow on PRs. I'm fine to discard this PR if someone comes up with a fix forward solution.
Confirms it fixes this Podfile that broke in 1.15.0: