Don't use :remove_destination option to FileUtils.cp_r

[justinseanmartin]

The docs for FileUtils.cp_r state:

If remove_destination is true, this method removes each destination file before copy.

This isn't the behavior like rsync --delete provides, where it removes extraneous files. Instead, it seems like this feature was added to Ruby to deal with cases where the file being copied over is potentially actively in use during the copy operation. Instead of overwriting the file, it'll unlink the file first here, which allows open file handles to continue accessing the old file contents.

In any case, the solution is to go back to the previous behavior of doing an rm_rf before the cp_r. Alternatively, we could use rsync --delete here as well, like we did here, but I'd rather minimize the churn.

Without this, the behavior that we were seeing is that we'd end up with an pod install output like:

> Copying PodFramework from /Users/jmartin/Library/Caches/CocoaPods/ios-register/Pods/Release/PodFramework/1.2.3-134c1 to Pods/PodFramework

And we'd end up with the new pods content installed into Pods/PodFramework/1.2.3-134c1 instead of into the root directory. By removing the PodFramework destination directory before the call to cp_r, we will restore the previous expected behavior.