Optimize performance during uncached pod installation. #12154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
from
4a3b016
to
3da7eee
Compare
dnkoutso
commented
Nov 19, 2023
| @@ -15,7 +15,7 @@ def initialize(root, specs_by_platform) | |||
| # @return [void] | |||
| # | |||
| def clean! | |||
| clean_paths.each { |path| FileUtils.rm_rf(path) } if root.exist? | |||
| FileUtils.rm_rf(clean_paths) if root.exist? | |||
dnkoutso
commented
Nov 19, 2023
| @@ -51,8 +51,7 @@ def self.download( | |||
| if target && result.location && target != result.location | |||
| UI.message "Copying #{request.name} from `#{result.location}` to #{UI.path target}", '> ' do | |||
| Cache.read_lock(result.location) do | |||
| FileUtils.rm_rf target | |||
| FileUtils.cp_r(result.location, target) | |||
| FileUtils.cp_r(result.location, target, :remove_destination => true) | |||
There was a problem hiding this comment.
minor optimization
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
from
3da7eee
to
b1e250b
Compare
|
@paulb777 I checked Firebase can be installed which includes a prepare_command with this change. |
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
3 times, most recently
from
a3fb18f
to
93c35d6
Compare
dnkoutso
commented
Nov 19, 2023
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
4 times, most recently
from
63d1347
to
add1460
Compare
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
from
add1460
to
781c5b5
Compare
dnkoutso
changed the title
justinseanmartin
approved these changes
Nov 20, 2023
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
7 times, most recently
from
05ab212
to
940242c
Compare
we could add Firebase with a prepare command as an example to build and test. |
paulb777
approved these changes
Nov 20, 2023
@paulb internally in a repo of ours that basically drove this change, we now see something that took a minute or two down to 15-20 seconds! |
dnkoutso
force-pushed
the
optimize_pod_dir_cleaning
branch
from
940242c
to
4b2968f
Compare
|
Our internal repo basically offers 10s of pods and the repo has gotten larger which is now much faster to setup and correctly. |
|
@dnkoutso @justinseanmartin this change is busting cocoapods for me in some apps. Here's a gist of what I ran into :
|
|
Will take a look. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing pods from a given repo, we are currently over-doing a bunch of unnecessary work by copying the original repo from within a temp dir N times as many pods we are installing from that repo. We then trim (clean) the copied repo to the files that are only relevant to the pod we are installing.
This can be very slow if a repo is large and offers multiple podspecs.
We also need to do this work only if there is a prepare command to run which currently operates or can operate against the initial cloned repo.
The PR here optimizes by splitting pods that require a
prepare_commandand ones that do not. For the ones that need one we execute the existing behavior but for the ones that do not, we trim the cloned repo and then copy exactly the files we need.This can speed up installation dramatically for repos that publish multiple podspecs.