Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [n]byte/[]byte type Scan/Append to FixedString column #1205

Merged

Conversation

rogeryk
Copy link
Contributor

@rogeryk rogeryk commented Feb 27, 2024

Summary

Support [n]byte/[]byte type Scan/Append to FixedString column

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added

closes #1155

@jkaflik jkaflik self-requested a review February 27, 2024 15:26
@@ -150,6 +203,8 @@ func (col *FixedString) Append(v any) (nulls []uint8, err error) {
func (col *FixedString) AppendRow(v any) (err error) {
data := make([]byte, col.col.Size)
switch v := v.(type) {
case []byte:
copy(data, v)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why copy instead of assign slice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The length of slice may not equal col.col.Size. Use copy to cover overlap scenarios

@jkaflik jkaflik self-assigned this Feb 28, 2024
@jkaflik jkaflik merged commit fe80908 into ClickHouse:main Feb 28, 2024
13 checks passed
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 12, 2024
….21.1 (#31065)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go)
| `v2.17.1` -> `v2.21.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.1/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.1/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.21.1`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.1)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.0...v2.21.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Fixes 🐛

- Adds the ability to Append a zero valued time.Time by
[@&#8203;KevinJoiner](https://togithub.com/KevinJoiner) in
[ClickHouse/clickhouse-go#1228

#### New Contributors

- [@&#8203;KevinJoiner](https://togithub.com/KevinJoiner) made their
first contribution in
[ClickHouse/clickhouse-go#1228

**Full Changelog**:
ClickHouse/clickhouse-go@v2.21.0...v2.21.1

###
[`v2.21.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.0)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.20.0...v2.21.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Enhancements 🎉

- Stream HTTP response body read for decompression by
[@&#8203;rogeryk](https://togithub.com/rogeryk) in
[ClickHouse/clickhouse-go#1213

##### Fixes 🐛

- Fix Date32 extremes values handling by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1218
- Fix column with double quotes PrepareBatch
failed.([#&#8203;1216](https://togithub.com/ClickHouse/clickhouse-go/issues/1216))
by [@&#8203;YenchangChan](https://togithub.com/YenchangChan) in
[ClickHouse/clickhouse-go#1217
- Fix an obscure error in HTTP protocol with LZ4 compression by
[@&#8203;YenchangChan](https://togithub.com/YenchangChan) in
[ClickHouse/clickhouse-go#1230

##### Other Changes 🛠

- Replace deprecated `io/ioutil` functions with equivalents by
[@&#8203;zaneli](https://togithub.com/zaneli) in
[ClickHouse/clickhouse-go#1211
- Run cloud workflow on main branch only by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1219
- ClickHouse 24.2 by [@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1220

**Full Changelog**:
ClickHouse/clickhouse-go@v2.20.0...v2.21.0

###
[`v2.20.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2200-2024-02-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.19.0...v2.20.0)

#### What's Changed

##### Enhancements 🎉

- Support \[n]byte/\[]byte type Scan/Append to FixedString column by
[@&#8203;rogeryk](https://togithub.com/rogeryk) in
[ClickHouse/clickhouse-go#1205

##### Other Changes 🛠

- Enable cloud tests by [@&#8203;jkaflik](https://togithub.com/jkaflik)
in
[ClickHouse/clickhouse-go#1202
- Removed LowCardinality(UInt64) tests that caused
allow_suspicious_low_cardinality_types related error by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1206

**Full Changelog**:
ClickHouse/clickhouse-go@v2.19.0...v2.20.0

###
[`v2.19.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2190-2024-02-26----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.18.0...v2.19.0)

#### What's Changed

##### Enhancements 🎉

- handle ctx.Done() in acquire by
[@&#8203;threadedstream](https://togithub.com/threadedstream) in
[ClickHouse/clickhouse-go#1199

##### Fixes 🐛

- Fix panic on format nil \*fmt.Stringer type value by
[@&#8203;zaneli](https://togithub.com/zaneli) in
[ClickHouse/clickhouse-go#1200

##### Other Changes 🛠

- Update Go/ClickHouse versions by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1201

#### New Contributors

- [@&#8203;threadedstream](https://togithub.com/threadedstream) made
their first contribution in
[ClickHouse/clickhouse-go#1199
- [@&#8203;zaneli](https://togithub.com/zaneli) made their first
contribution in
[ClickHouse/clickhouse-go#1200

**Full Changelog**:
ClickHouse/clickhouse-go@v2.18.0...v2.19.0

###
[`v2.18.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2180-2024-02-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.17.1...v2.18.0)

#### What's Changed

##### Enhancements 🎉

- Add WithAllocBufferColStrProvider string column allocator for batch
insert performance boost by
[@&#8203;hongker](https://togithub.com/hongker) in
[ClickHouse/clickhouse-go#1181

##### Fixes 🐛

- Fix bind for seconds scale DateTime by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1184

##### Other Changes 🛠

- resolves
[#&#8203;1163](https://togithub.com/ClickHouse/clickhouse-go/issues/1163)
debugF function is not respected by
[@&#8203;omurbekjk](https://togithub.com/omurbekjk) in
[ClickHouse/clickhouse-go#1166

#### New Contributors

- [@&#8203;omurbekjk](https://togithub.com/omurbekjk) made their first
contribution in
[ClickHouse/clickhouse-go#1166
- [@&#8203;hongker](https://togithub.com/hongker) made their first
contribution in
[ClickHouse/clickhouse-go#1181

**Full Changelog**:
ClickHouse/clickhouse-go@v2.17.1...v2.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
….21.1 (open-telemetry#31065)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go)
| `v2.17.1` -> `v2.21.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.1/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.1/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.21.1`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.1)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.0...v2.21.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Fixes 🐛

- Adds the ability to Append a zero valued time.Time by
[@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) in
[ClickHouse/clickhouse-go#1228

#### New Contributors

- [@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) made their
first contribution in
[ClickHouse/clickhouse-go#1228

**Full Changelog**:
ClickHouse/clickhouse-go@v2.21.0...v2.21.1

###
[`v2.21.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.0)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.20.0...v2.21.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Enhancements 🎉

- Stream HTTP response body read for decompression by
[@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in
[ClickHouse/clickhouse-go#1213

##### Fixes 🐛

- Fix Date32 extremes values handling by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1218
- Fix column with double quotes PrepareBatch
failed.([#&open-telemetry#8203;1216](https://togithub.com/ClickHouse/clickhouse-go/issues/1216))
by [@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in
[ClickHouse/clickhouse-go#1217
- Fix an obscure error in HTTP protocol with LZ4 compression by
[@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in
[ClickHouse/clickhouse-go#1230

##### Other Changes 🛠

- Replace deprecated `io/ioutil` functions with equivalents by
[@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in
[ClickHouse/clickhouse-go#1211
- Run cloud workflow on main branch only by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1219
- ClickHouse 24.2 by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1220

**Full Changelog**:
ClickHouse/clickhouse-go@v2.20.0...v2.21.0

###
[`v2.20.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2200-2024-02-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.19.0...v2.20.0)

#### What's Changed

##### Enhancements 🎉

- Support \[n]byte/\[]byte type Scan/Append to FixedString column by
[@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in
[ClickHouse/clickhouse-go#1205

##### Other Changes 🛠

- Enable cloud tests by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik)
in
[ClickHouse/clickhouse-go#1202
- Removed LowCardinality(UInt64) tests that caused
allow_suspicious_low_cardinality_types related error by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1206

**Full Changelog**:
ClickHouse/clickhouse-go@v2.19.0...v2.20.0

###
[`v2.19.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2190-2024-02-26----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.18.0...v2.19.0)

#### What's Changed

##### Enhancements 🎉

- handle ctx.Done() in acquire by
[@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) in
[ClickHouse/clickhouse-go#1199

##### Fixes 🐛

- Fix panic on format nil \*fmt.Stringer type value by
[@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in
[ClickHouse/clickhouse-go#1200

##### Other Changes 🛠

- Update Go/ClickHouse versions by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1201

#### New Contributors

- [@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) made
their first contribution in
[ClickHouse/clickhouse-go#1199
- [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) made their first
contribution in
[ClickHouse/clickhouse-go#1200

**Full Changelog**:
ClickHouse/clickhouse-go@v2.18.0...v2.19.0

###
[`v2.18.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2180-2024-02-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.17.1...v2.18.0)

#### What's Changed

##### Enhancements 🎉

- Add WithAllocBufferColStrProvider string column allocator for batch
insert performance boost by
[@&open-telemetry#8203;hongker](https://togithub.com/hongker) in
[ClickHouse/clickhouse-go#1181

##### Fixes 🐛

- Fix bind for seconds scale DateTime by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1184

##### Other Changes 🛠

- resolves
[#&open-telemetry#8203;1163](https://togithub.com/ClickHouse/clickhouse-go/issues/1163)
debugF function is not respected by
[@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) in
[ClickHouse/clickhouse-go#1166

#### New Contributors

- [@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) made their first
contribution in
[ClickHouse/clickhouse-go#1166
- [@&open-telemetry#8203;hongker](https://togithub.com/hongker) made their first
contribution in
[ClickHouse/clickhouse-go#1181

**Full Changelog**:
ClickHouse/clickhouse-go@v2.17.1...v2.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
….21.1 (open-telemetry#31065)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go)
| `v2.17.1` -> `v2.21.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.1/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.17.1/v2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.21.1`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.1)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.0...v2.21.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Fixes 🐛

- Adds the ability to Append a zero valued time.Time by
[@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) in
[ClickHouse/clickhouse-go#1228

#### New Contributors

- [@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) made their
first contribution in
[ClickHouse/clickhouse-go#1228

**Full Changelog**:
ClickHouse/clickhouse-go@v2.21.0...v2.21.1

###
[`v2.21.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.0)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.20.0...v2.21.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Enhancements 🎉

- Stream HTTP response body read for decompression by
[@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in
[ClickHouse/clickhouse-go#1213

##### Fixes 🐛

- Fix Date32 extremes values handling by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1218
- Fix column with double quotes PrepareBatch
failed.([#&open-telemetry#8203;1216](https://togithub.com/ClickHouse/clickhouse-go/issues/1216))
by [@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in
[ClickHouse/clickhouse-go#1217
- Fix an obscure error in HTTP protocol with LZ4 compression by
[@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in
[ClickHouse/clickhouse-go#1230

##### Other Changes 🛠

- Replace deprecated `io/ioutil` functions with equivalents by
[@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in
[ClickHouse/clickhouse-go#1211
- Run cloud workflow on main branch only by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1219
- ClickHouse 24.2 by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1220

**Full Changelog**:
ClickHouse/clickhouse-go@v2.20.0...v2.21.0

###
[`v2.20.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2200-2024-02-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.19.0...v2.20.0)

#### What's Changed

##### Enhancements 🎉

- Support \[n]byte/\[]byte type Scan/Append to FixedString column by
[@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in
[ClickHouse/clickhouse-go#1205

##### Other Changes 🛠

- Enable cloud tests by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik)
in
[ClickHouse/clickhouse-go#1202
- Removed LowCardinality(UInt64) tests that caused
allow_suspicious_low_cardinality_types related error by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1206

**Full Changelog**:
ClickHouse/clickhouse-go@v2.19.0...v2.20.0

###
[`v2.19.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2190-2024-02-26----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.18.0...v2.19.0)

#### What's Changed

##### Enhancements 🎉

- handle ctx.Done() in acquire by
[@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) in
[ClickHouse/clickhouse-go#1199

##### Fixes 🐛

- Fix panic on format nil \*fmt.Stringer type value by
[@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in
[ClickHouse/clickhouse-go#1200

##### Other Changes 🛠

- Update Go/ClickHouse versions by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1201

#### New Contributors

- [@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) made
their first contribution in
[ClickHouse/clickhouse-go#1199
- [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) made their first
contribution in
[ClickHouse/clickhouse-go#1200

**Full Changelog**:
ClickHouse/clickhouse-go@v2.18.0...v2.19.0

###
[`v2.18.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2180-2024-02-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.17.1...v2.18.0)

#### What's Changed

##### Enhancements 🎉

- Add WithAllocBufferColStrProvider string column allocator for batch
insert performance boost by
[@&open-telemetry#8203;hongker](https://togithub.com/hongker) in
[ClickHouse/clickhouse-go#1181

##### Fixes 🐛

- Fix bind for seconds scale DateTime by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1184

##### Other Changes 🛠

- resolves
[#&open-telemetry#8203;1163](https://togithub.com/ClickHouse/clickhouse-go/issues/1163)
debugF function is not respected by
[@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) in
[ClickHouse/clickhouse-go#1166

#### New Contributors

- [@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) made their first
contribution in
[ClickHouse/clickhouse-go#1166
- [@&open-telemetry#8203;hongker](https://togithub.com/hongker) made their first
contribution in
[ClickHouse/clickhouse-go#1181

**Full Changelog**:
ClickHouse/clickhouse-go@v2.17.1...v2.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
@jerbob92
Copy link

jerbob92 commented May 15, 2024

Just to let you know: this has broken our code to save XID's as FixedString(20) in CH. This is due to that the XID is actually an alias for a byte array (type ID [rawLen]byte), so it's now hitting the new code. XID's in byte format are 12 bytes, but in string format it's 20. Since XID has implemented the driver.Valuer interface, it would normally have hit this block:

if s, ok := v.(driver.Valuer); ok {
	val, err := s.Value()
	if err != nil {
		return &ColumnConverterError{
			Op:   "AppendRow",
			To:   "FixedString",
			From: fmt.Sprintf("%T", s),
			Hint: "could not get driver.Valuer value",
		}
	}
	return col.AppendRow(val)
}

Internally, this would stringify the XID and thus make them a length of 20.

But since this change it's hitting the byte array block and resulting in the following error:

clickhouse [AppendRow]: converting xid.ID to FixedString is unsupported. invalid size 12, expect 20

My suggestion would be to move the handling of the byte array to below the driver.Valuer/Stringer handling, imho in case of FixedString, the driver.Valuer/Stringer handling should have precedence over other handling.

@rogeryk
Copy link
Contributor Author

rogeryk commented May 16, 2024

@jerbob92 Sounds right, I think should create a new issue and file a PR to fix it.

@jerbob92
Copy link

@rogeryk or maybe @jkaflik should revert it and you should make a new PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

converting []uint8 to FixedString is unsupported
3 participants