Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send query on batch retry #1045

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fix send query on batch retry #1045

merged 3 commits into from
Aug 2, 2023
+40 −4

Conversation

EpicStep
Copy link
Contributor

Hi, now retry() create empty connection, without INSERT INTO statement, because of this, it cannot be used.

@EpicStep
Fix send batch retry

Verified

This commit was signed with the committer’s verified signature.
MadVikingGod Aaron Clawson
GPG key ID: 9B219B3C9BBA18F4
Verified
Learn about vigilant mode
b5b0ecc
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@EpicStep
Fix 798 issue test

Verified

This commit was signed with the committer’s verified signature.
MadVikingGod Aaron Clawson
GPG key ID: 9B219B3C9BBA18F4
Verified
Learn about vigilant mode
8d13ccd
@EpicStep
Copy link
Contributor Author

Hi @jkaflik, I think some tests are flaky, this is true?

@jkaflik
Copy link
Contributor

jkaflik commented Jul 31, 2023

Hi @EpicStep
Not really. This might be a regression with a recent ClickHouse version. I will be checking this.

@EpicStep
Copy link
Contributor Author

Hi @EpicStep
Not really. This might be a regression with a recent ClickHouse version. I will be checking this.

Okey, thanks you

@jkaflik jkaflik self-requested a review August 1, 2023 14:04
@jkaflik
Copy link
Contributor

jkaflik commented Aug 2, 2023

@EpicStep I will release this today

@jkaflik
Merge branch 'main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8a72c03
@jkaflik jkaflik changed the title Fix send batch retry Send query on batch retry Aug 2, 2023
jkaflik
jkaflik approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkaflik jkaflik changed the title Send query on batch retry Fix send query on batch retry Aug 2, 2023
@jkaflik jkaflik merged commit 176620a into ClickHouse:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EpicStep @CLAassistant @jkaflik