Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete methods: RemovePath and RemoveLocations #7860

Merged

Conversation

JesseXia
Copy link
Contributor

Summary

According to graphql spec -

The path and the error is always required in the field execution context.

The existing methods are now obsolete.

Closes #7828

@JesseXia JesseXia marked this pull request as ready for review December 23, 2024 00:30
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (df2f85d) to head (113728e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7860   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files        2898     2898           
  Lines      152316   152310    -6     
  Branches    17782    17779    -3     
=======================================
- Hits       113319   113317    -2     
+ Misses      33099    33097    -2     
+ Partials     5898     5896    -2     
Flag Coverage Δ
unittests 74.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib added this to the HC-15.0.0 milestone Jan 29, 2025
@michaelstaib michaelstaib self-assigned this Jan 29, 2025
@michaelstaib michaelstaib merged commit b8fcc1c into ChilliCream:main Feb 4, 2025
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RemoveLocation and RemovePath methods from error and error builder.
2 participants