This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fix(validator): generate abi name if not provided #6981
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of public mappings, the ABI generated has a blank name set. This results in blank ids for such inputs within the JSON schema. Post 1f81ff0, the number of unique ids is used to convert the JSON scheme into Zod, and hence the presence of blank ids is a concern. This commit generates the `abiName` if one is not provided to a value equal to the `${level}/${index}`. Fixes web3#6965.
MaxMustermann2
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
|
I'll ping the devs to review this ASAP, @MaxMustermann2 thanks for fixing it! |
luu-alex
approved these changes
Apr 18, 2024
|
Thanks for the PR! @MaxMustermann2 |
jdevcs
approved these changes
Apr 22, 2024
avkos
approved these changes
Apr 22, 2024
Merged
This was referenced Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of public mappings, the ABI generated has a blank name set. This results in blank ids for such inputs within the JSON schema. Post 1f81ff0, the number of unique ids is used to convert the JSON scheme into Zod, and hence the presence of blank ids is a concern.
This commit generates the
abiNameif one is not provided, to a value equal to the${level}/${index}.Fixes #6965.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.