This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
+111
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6855 +/- ##
=======================================
Coverage 92.06% 92.07%
=======================================
Files 215 215
Lines 8212 8222 +10
Branches 2208 2209 +1
=======================================
+ Hits 7560 7570 +10
Misses 652 652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mpetrunic
reviewed
Mar 5, 2024
mpetrunic
approved these changes
Mar 5, 2024
avkos
approved these changes
Mar 5, 2024
This was referenced Mar 25, 2024
This was referenced Mar 25, 2024
This was referenced Mar 25, 2024
This was referenced Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related with: #6201
#6859
now
requestEIP6963Providers
return promise resolving toMap<string, EIP6963ProviderDetail>
containing providers list, and it will emitweb3:providersMapUpdated
event for any update to above map objType of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.