-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. with your fix, it will be two web3-types
imports. it will be better to move the Eip712TypedData
import to the previous import
import {
Address,
BlockNumberOrTag,
Filter,
HexString32Bytes,
HexString8Bytes,
HexStringBytes,
TransactionCallAPI,
TransactionWithSenderAPI,
Uint,
Uint256,
Web3EthExecutionAPI,
Eip712TypedData,
} from 'web3-types';
That makes sense. I didn't even look that closely to see that there was already a 'web3-types' import |
I updated the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dangarbri
Could you also, please, update the CHANGELOG.md at packages/web3-rpc-methods to inform about the issues fixed in this MR?
I'll be able to update it later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dangarbri for your contribution.
I updated the CHANGELOG.md file.
Thanks, sorry I didn't get around to it. |
Description
Fix import
Fixes #6589
Type of change
Checklist:
I did not do most of the things below because I don't have a dev environment set up for this...
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.