Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

'disconnect' in Eip1193 provider must emit ProviderRpcError #6003

Closed
2 tasks done
nikoulai opened this issue Apr 11, 2023 · 0 comments · Fixed by #6230
Closed
2 tasks done

'disconnect' in Eip1193 provider must emit ProviderRpcError #6003

nikoulai opened this issue Apr 11, 2023 · 0 comments · Fixed by #6230
Assignees
@Muhammad-Altabba
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@nikoulai
Copy link
Contributor

This is not a Bug Report, Feature Request, or related to Documentation

  • I have searched the existing issues

Is there an existing issue for this?

  • I have searched the existing issues

What's up?

In packages/web3-utils/src/web3_eip1193_provider.ts _onDisconnect emits an object with code and data.

The EIP states that it should be of type ProviderRpcError

Examples/References

No response
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Muhammad-Altabba Muhammad-Altabba

Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: 'disconnect' in Eip1193 provider must emit ProviderRpcError web3/web3.js
3 participants
@nikoulai @Muhammad-Altabba @mconnelly8