Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Libs and CI updates #5014

Merged
merged 5 commits into from
May 16, 2022
Merged

Libs and CI updates #5014

merged 5 commits into from
May 16, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 9, 2022

Description

Libs and CI node.js version update before next release:

  • npm audit fix
  • CI node.js version updated for build and tests.

Fixes #5020

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Sorry, something went wrong.

@render
Copy link

render bot commented May 9, 2022

@jdevcs
Copy link
Contributor Author

jdevcs commented May 9, 2022

For following I will update 1x branch rule in repo settings:

unit (11) Expected — Waiting for status to be reported
Required

unit (13) Expected — Waiting for status to be reported
Required

This will effect all other 1x PRs as well.

@jdevcs jdevcs self-assigned this May 9, 2022
@coveralls
Copy link

coveralls commented May 9, 2022

Pull Request Test Coverage Report for Build 2300066762

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 429 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.211%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 2270215922: -2.3%
Covered Lines: 3372
Relevant Lines: 4401

💛 - Coveralls

@jdevcs jdevcs marked this pull request as ready for review May 10, 2022 10:52
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any issue which document why are removing support for 11 and 13?

@jdevcs jdevcs requested a review from nazarhussain May 12, 2022 18:28
@jdevcs
Copy link
Contributor Author

jdevcs commented May 13, 2022

Is there any issue which document why are removing support for 11 and 13?

@nazarhussain
Its already linked in zenhub as well.

#5020

https://nodejs.org/en/about/releases/

@nazarhussain nazarhussain changed the title libs and CI update Libs and CI updates May 13, 2022
@nazarhussain
Copy link
Contributor

@jdevcs Try to mention the issue in the PR description, it's the part of the PR template as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libs and CI update
4 participants