Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix dead link in web3-eth.rst #4916

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Fix dead link in web3-eth.rst #4916

merged 7 commits into from
Apr 11, 2022

Conversation

GitHubPang
Copy link

@GitHubPang GitHubPang commented Apr 4, 2022

Description

Updated link to match with that on line 757.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Updated link to match with that on line 757.

Verified

This commit was signed with the committer’s verified signature.
@nazarhussain nazarhussain added Documentation Relates to project wiki or documentation 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Apr 6, 2022

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
GitHubPang and others added 2 commits April 8, 2022 07:56
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@jdevcs jdevcs merged commit 644a855 into web3:1.x Apr 11, 2022
@jdevcs jdevcs mentioned this pull request May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants