Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix static tuple encoding (#4673) #4884

Merged
merged 8 commits into from
Apr 12, 2022
Merged

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Mar 23, 2022

Description

Testing #4673 for e2e windows tests in this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jdevcs jdevcs added the 1.x 1.0 related issues label Mar 23, 2022
@jdevcs jdevcs self-assigned this Mar 23, 2022
@render
Copy link

render bot commented Mar 23, 2022

@coveralls
Copy link

coveralls commented Mar 23, 2022

Pull Request Test Coverage Report for Build 2155661188

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 443 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.217%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-eth-abi/lib/index.js 14 90.19%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 2155436639: -2.3%
Covered Lines: 3372
Relevant Lines: 4401

💛 - Coveralls

Unverified

This user has not yet uploaded their public signing key.
jdevcs and others added 6 commits March 23, 2022 16:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jdevcs jdevcs merged commit 5a437ce into 1.x Apr 12, 2022
@jdevcs jdevcs deleted the junaid/fixstatictupleencoding4673 branch April 12, 2022 14:49
@jdevcs jdevcs mentioned this pull request May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants