-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript support #3652
Add typescript support #3652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two commented imports, lgtm!
a8090d4
to
109e0c5
Compare
b124b01
to
27a22e1
Compare
27a22e1
to
7fdf653
Compare
fe2989e
to
d652438
Compare
d652438
to
b0cb0ea
Compare
@spacesailor24 and @ryanio I updated the changelog and addressed a previous comment. Ready for re-review. |
@GregTheGreek looks good 👍 in the past we have only merged changes to |
hmm let me look at that, i thought i pulled in the ones from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR focuses on adding TypeScript in an incremental way. Currently
allowJs
is enabled allowing us to write TypeScript and JavaScript side by side. The configuration is very lenient, and in the future as we make progress on the typescript interfaces we should tighten it up.It also:
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.