This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
+220
−1,612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ens config, new regsitry address defined in ens config, and related ens tests updated
holgerd77
reviewed
Jan 31, 2020
10 tasks
cgewecke
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
michaelsbradleyjr
approved these changes
Jan 31, 2020
Arachnid
approved these changes
Feb 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do whatever is necessary to update web3 - users who do not update will start seeing stale results on Monday, and we still need to encourage developers to use the new library once it is released!
@holgerd77 @michaelsbradleyjr @cgewecke @Arachnid version 1.2.6 of web3.js got successfully released. |
12 tasks
Closed because PR #3355 will apply those required changes on 1.x without reverting of improvements we already have done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This release does add the Görli testnet to the ENS config and does update the Registry address.
This is a security patch release and should get published today.
Release Guideline
Added
Changed
Compare View
v1.2.5 -> v1.2.6
Type of change
Checklist:
npm run test
with success and extended the tests if necessary.npm run build
and tested the resulting file fromdist
folder in a browser.