Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring in ethereum-bloom-filters #3137

Merged
merged 7 commits into from Oct 17, 2019
Merged

feat: bring in ethereum-bloom-filters #3137

merged 7 commits into from Oct 17, 2019

Conversation

joshstevens19
Copy link
Contributor

@joshstevens19 joshstevens19 commented Oct 16, 2019

  • blooms in web3 were never exposed and had a few bugs in them. The package has fixed them all and fully 100% tested
  • blooms is not used enough client side and this library is a single point of truth for related bloom stuff
  • will go into web3 and etherjs so they share the same codebase

@nivida the package itself has all the docs so Sam said he will extend the web3 docs to reference them, he knows how he wants that showing so leaving that part to him.

@coveralls
Copy link

coveralls commented Oct 16, 2019

Coverage Status

Coverage decreased (-0.09%) to 84.78% when pulling 3d74bd3 on joshstevens19:feat/use-blooms-lib into 400d24b on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Feature Request In Progress Currently being worked on labels Oct 17, 2019
@nivida nivida removed the In Progress Currently being worked on label Oct 17, 2019
@nivida nivida merged commit bf38b4e into web3:1.x Oct 17, 2019
@nivida nivida mentioned this pull request Oct 21, 2019
11 tasks
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
* feat: bring in `ethereum-bloom-filters`

* fix: add ` "no-redundant-jsdoc": false`

* fix: build

* bloom filters section added to docs

* CHANGELOG.md updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants