Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Network): add support for net id of Goerli #3095

Merged
merged 4 commits into from Oct 8, 2019
Merged

feat(Network): add support for net id of Goerli #3095

merged 4 commits into from Oct 8, 2019

Conversation

JayWelsh
Copy link
Contributor

@JayWelsh JayWelsh commented Oct 2, 2019

Support for identification of Goerli test net via getNetworkType function.

@coveralls
Copy link

coveralls commented Oct 2, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 83.242% when pulling c579ecb on JayWelsh:feature/add-goerli-identification-support-1.x into 5035b25 on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Enhancement Includes improvements or optimizations labels Oct 8, 2019
nivida
nivida suggested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@nivida nivida left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR! Could you update the changelog file in the root folder of the 1.x branch?

@nivida nivida merged commit c1db2ca into web3:1.x Oct 8, 2019
@JayWelsh
Copy link
Contributor Author

JayWelsh commented Oct 8, 2019

Thanks so much @nivida !

@nivida nivida mentioned this pull request Oct 21, 2019
Merged
11 tasks
@snyk-bot snyk-bot mentioned this pull request Nov 27, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@JayWelsh @nachomazzara
feat(Network): add support for net id of Goerli (web3#3095)
f2ff293 
* feat(Network): add support for net id of Goerli

* eth.net.getNetworkType test extended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JayWelsh @coveralls @nivida