Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hexToNumber and hexToNumberString prefix validation #3086

Merged
merged 3 commits into from Oct 15, 2019
Merged

Fix hexToNumber and hexToNumberString prefix validation #3086

merged 3 commits into from Oct 15, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Oct 1, 2019 •
edited

Fixes #2184 in the 1.x branch by back-porting #2884.

Notes

  • PR fixes both hexToNumber and hexToNumberString - fix(utils): hexToNumberString prefix validation #2884 only touched hexToNumberString. Possible 2.x needs a small addition there.

  • The existing hexToNumber tests look like they were mistakenly copy-pasted from hexToNumberString so have amended those.

@alcuadrado alcuadrado mentioned this pull request Oct 1, 2019
Closed
@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited

Coverage Status

Coverage increased (+0.03%) to 82.976% when pulling e832bdb on cgewecke:backport/2884 into 2e84152 on ethereum:1.x.

@cgewecke cgewecke added the 1.x 1.0 related issues label Oct 1, 2019
@cgewecke cgewecke changed the title Fix hexToNumber and hexToNumberString prefix validation [WIP] Fix hexToNumber and hexToNumberString prefix validation Oct 3, 2019
@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Oct 8, 2019
@nivida nivida changed the title [WIP] Fix hexToNumber and hexToNumberString prefix validation Fix hexToNumber and hexToNumberString prefix validation Oct 8, 2019
@cgewecke
Copy link
Collaborator Author

@nivida I checked the hexToNumber change on the E2E PR (#3122) and it looks ok...

I think you're correct and this is merge-able.

@nivida nivida removed the In Progress Currently being worked on label Oct 15, 2019
@nivida nivida merged commit 4178371 into web3:1.x Oct 15, 2019
@nivida nivida mentioned this pull request Oct 21, 2019
Merged
11 tasks
@snyk-bot snyk-bot mentioned this pull request Nov 27, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@cgewecke @nachomazzara
Fix hexToNumber and hexToNumberString prefix validation (web3#3086)
13813fe 
* fix hexToNumber & hexToNumberString  prefix validation

* CHANGELOG.md updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida left review comments

Assignees
No one assigned
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cgewecke @coveralls @nivida @yzevm