Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - Add an Intent Chooser as an alternate to current Alert Dialog to choose image source #325

Closed
Devenom1 opened this issue Mar 6, 2022 · 8 comments · Fixed by #326

Comments

@Devenom1
Copy link
Contributor

Devenom1 commented Mar 6, 2022

I've like the way you've maintained this library. I have added an alternate to choose the image source. You currently have and AlertDialog to choose from Camera or Gallery apps. I would like to add an intent chooser as an alternate. It seems to be working well on all android versions I've tested it on so far.

I'll add a PR for it

@Canato
Copy link
Member

Canato commented Mar 7, 2022

Thanks =D!

We make this change because of the bugs we have related to MIUI (Xiaomi)

  1. PR
  2. BUG - MIUI (Xiaomi) cant pick image from gallery
  3. BUG - FileUriExposedException when trying to lunch only camera intent

+ (Not following the templates, but the same issue about MIUI)

We need to be sure this is fixed and/or give the user the option to use intent chooser instead of default Alert Dialog

@Devenom1
Copy link
Contributor Author

Devenom1 commented Mar 7, 2022

I have been checking the issues you mentioned above. I'm not sure I've managed to fix all these issues.

Our apps have between 5k-20k users as of now. In one of our apps the ArthurHub version of the library that I modified is used a lot. This app is mostly being used by users with Mi, Vivo, and Oppo phones. We have a close interaction with these users and we've faced a lot of issues you've mentioned above.

I've managed to make fixes for most of these issues mentioned above. I myself have an Mi Phone (MIUI) running Android 11 and I've tested it using someone else's phone that had MIUI and Android 12. Also all our users with Mi, Vivo, Oppo and other Chinese brands have been uploading images using my modified library without any issue.

There's no optimal way to check if the issues are 100% resolved but I feel most of them are.

Could we maybe find a way to keep the intent chooser optional? And if any issues come by we can try and fix them

@Canato
Copy link
Member

Canato commented Mar 7, 2022

Could we maybe find a way to keep the intent chooser optional? And if any issues come by we can try and fix them

Yes, I think this is the best option. So who prefer Intent Chooser can select ir

@Devenom1
Copy link
Contributor Author

Devenom1 commented Mar 7, 2022

Alright. Awesome @Canato I will try and make that an option. I will also update the required documentation you mentioned in the PR. If you have any tech input about how we can keep this intent chooser optional without changing much of the code it would be great. I'll still try to find a good way to do it

@Canato
Copy link
Member

Canato commented Mar 7, 2022

If you have any tech input about how we can keep this intent chooser optional without changing much of the code it would be great.

I believe the easy solutions is a simple Boolean option for AlertDialog or Default intent into the library options, like we have for skip PR you did

If you want, you can make both in the same PR, just need 2 changelog entries. Or we can keep split

@stale
Copy link

stale bot commented Mar 23, 2022

Let's keep this mess organised! This issue has been automatically marked as stale because it has not had recent activity. =( It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 23, 2022
@Devenom1
Copy link
Contributor Author

Devenom1 commented Mar 23, 2022

Alright. I'm reworking the intent chooser code as per your suggestions. Will try to get it live asap. How do I get rid of the stale label?

@stale stale bot removed the stale label Mar 23, 2022
@Canato
Copy link
Member

Canato commented Mar 23, 2022

Alright. I'm reworking the intent chooser code as per your suggestions. Will try to get it live asap. How do I get rid of the stale label?

Automatically when someone update it ^^

@Canato Canato mentioned this issue Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants