Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fixed type for .focus() #1379

Merged
merged 2 commits into from
Apr 30, 2024
Merged

types: fixed type for .focus() #1379

merged 2 commits into from
Apr 30, 2024

Conversation

hinogi
Copy link
Contributor

@hinogi hinogi commented Mar 11, 2024

Description

Add a short description of:

  • what changes you made,
  • why you made them, and
  • any other context that you think might be helpful for someone to better understand what is contained in this pull request.

This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

@hinogi hinogi requested a review from samijaber as a code owner March 11, 2024 11:25
Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 22f6a5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:11pm

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this issue!

@samijaber samijaber merged commit 4664fb4 into BuilderIO:main Apr 30, 2024
5 of 6 checks passed
Copy link

nx-cloud bot commented Apr 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 22f6a5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants