-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browser-sync tried to access chalk, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound #2021
Comments
Can you try |
Thanks @shakyShane, that fixes it! 👍 Would you mind also fixing it for your eazy-logger? Same issue there: Thanks! |
Mhm, just noticed, that eazy-logger is defined without a https://github.com/BrowserSync/browser-sync/blob/master/packages/browser-sync/package.json#L48 Meaning it issue still happens in eazy-logger and because it is hard linked to 4.0.0 fixing & bumping eazy-logger won't fix the issue either and another bump of browser-sync will be required. Sorry for that. |
@kristian try |
Jep, that fixed it! Thanks @shakyShane 🙏🏻 |
@kristian thanks for bringing it to my attention |
Very welcome, have a good one 👍 |
Issue details
Executing browser-sync with Yarn 2 PnP gives the following error:
Steps to reproduce/test case
Use browser-sync with Yarn 2
Checked in
package.json
file and indeedchalk
is only defined as adevDependency
however, because it is used in the public API, which is exposed to dependent packages it should be adependency
instead.The text was updated successfully, but these errors were encountered: