tokenUtxoDetails: fixed bug where UTXO array elems would switch #81
+235
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christroutner
commented
Dec 16, 2019
| thisUtxo.vout !== 1 // UTXO is not the reciever of the genesis or mint tokens. | ||
| ) { | ||
| // Can safely be marked as false. | ||
| outAry[i] = false |
There was a problem hiding this comment.
These are the main changes in this PR. They center around more careful handling of the arrays and their elements.
christroutner
commented
Dec 16, 2019
| } | ||
| } | ||
| } | ||
|
|
||
| return validations | ||
| return outAry |
There was a problem hiding this comment.
I changed the output variable name from validations to outAry. That's confusing git diff, and making it appear that I changed much more code than I actually did.
christroutner
commented
Dec 16, 2019
| @@ -210,12 +210,12 @@ describe("#Utils", () => { | |||
| // Mock the call to rest.bitcoin.com | |||
| if (process.env.TEST === "unit") { | |||
| sandbox | |||
| .stub(axios, "get") | |||
| .stub(axios, "post") | |||
There was a problem hiding this comment.
I fixed this minor mocking bug while I was at it.
christroutner
commented
Dec 16, 2019
| @@ -1059,5 +1059,106 @@ describe("#Utils", () => { | |||
| "tokenQty" | |||
| ]) | |||
| }) | |||
|
|
|||
| it("should process problematic utxos", async () => { | |||
There was a problem hiding this comment.
I added this new test case, based on the UTXOs that were causing the bug for Pete. This new test case will ensure we don't see this bug again.
|
🎉 This PR is included in version 4.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that Pete discovered in tokenUtxoDetails. The bug was triggered inconsistently. It was caused by the the elements in a UTXO array getting out-of-order compared to the validatedTxid array. The changes to code fix it by using the
Array.filtermethod to make sure the right array element is being selected.The changes in this PR effect only two files. The rest are compiler noise.