fix: prevent trimming attempts on undefined value #389
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asennikov
commented
Apr 24, 2024
| @@ -15946,7 +15946,8 @@ const context = { | |||
| }), | |||
| ALIAS_DOMAINS: parser.getInput({ | |||
| key: 'ALIAS_DOMAINS', | |||
| type: 'array' | |||
| type: 'array', | |||
| disableable: true | |||
There was a problem hiding this comment.
not sure why this change happened, this is the result of running npm run build in the repo.
|
Please merge this 😭 |
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
I'm not sure what is the root cause for the command to return no stdout, but I think the
execCmdutility should be ready for that situation anyway.As it currently stands, we have been getting these errors since this morning: