Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimized scene.constructor #14483

Merged
merged 1 commit into from Nov 1, 2023
Merged

Conversation

GuoBinyong
Copy link
Contributor

The following optimizations have been made to 'scene.constructor':

  • Remove unnecessary non-runs from '!fullOptions.virtual'
  • Use the engine variable directly, instead of 'this._engine', which can improve the hit rate of the identifier;

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 1, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 1, 2023

@sebavan sebavan merged commit 9c95278 into BabylonJS:master Nov 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants