Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ground projection support #14470

Merged
merged 8 commits into from Oct 26, 2023
Merged

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Oct 26, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14470/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

packages/dev/core/src/Shaders/background.fragment.fx Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14470/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14470/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@deltakosh deltakosh enabled auto-merge (squash) October 26, 2023 19:31
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14470/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14470/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@deltakosh deltakosh merged commit 7037387 into BabylonJS:master Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants