Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world vs finalWorld fix in shader material #14469

Merged
merged 3 commits into from Oct 28, 2023

Conversation

RolandCsibrei
Copy link
Contributor

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 26, 2023

@RolandCsibrei RolandCsibrei marked this pull request as draft October 26, 2023 05:00
@sebavan sebavan requested a review from Popov72 October 26, 2023 10:22
@RaananW
Copy link
Member

RaananW commented Oct 27, 2023

should this still stay in draft? or ready to merge?

@Popov72
Copy link
Contributor

Popov72 commented Oct 27, 2023

I'm not sure why it is in draft mode: maybe @RolandCsibrei has more changes to commit?

@RolandCsibrei RolandCsibrei marked this pull request as ready for review October 28, 2023 15:23
@RolandCsibrei
Copy link
Contributor Author

I was not sure wheter the visualization tests will pass so I put it to draft. All went ok, you can merge, Thank you!

@RaananW RaananW merged commit 3c073f2 into BabylonJS:master Oct 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants