Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mesh without vertex normals to SPS #14464

Merged
merged 1 commit into from Oct 25, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj requested a review from Popov72 October 25, 2023 13:13
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2023

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems that the mesh is "upside down" when testing your PG. Perhaps the normals are inverted because the mesh comes from a glb file?

@sebavan sebavan merged commit 9c2993e into BabylonJS:master Oct 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants