Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateScreenshotUsingRenderTarget: Render to texture only when texture and camera are ready #14463

Merged
merged 2 commits into from Oct 25, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Oct 25, 2023

See https://forum.babylonjs.com/t/screenshot-with-post-process-not-includes-meshes/45168

Checking camera.isReady(true) make sure that post-processes are ready before going on.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2023

@sebavan sebavan merged commit 41b42a6 into BabylonJS:master Oct 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants