Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move type out of import clause #14459

Merged
merged 1 commit into from Oct 24, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 24, 2023

TypeScript 4.5 introduces inline type imports. But for anyone who uses typescript < 4.5 the build will fail.

There is no lint rule to disallow that, as it is a perfectly correct syntax. I will keep on checking for that.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 24, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 24, 2023

@sebavan
Copy link
Member

sebavan commented Oct 24, 2023

There is no lint rule to disallow that, as it is a perfectly correct syntax. I will keep on checking for that.

Would be great even if it is a custom one we add as I am pretty sure we will soon reintroduce it otherwise.

@sebavan sebavan merged commit 20a7143 into BabylonJS:master Oct 24, 2023
10 checks passed
@RaananW RaananW deleted the supportOlderTSVersions branch October 24, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants