Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in the mesh parsing code #14455

Merged
merged 1 commit into from Oct 24, 2023
Merged

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Oct 23, 2023

Causes overrideMaterialSideOrientation to be undefined

Fixes #14445

Causes `overrideMaterialSideOrientation` to be undefined
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 23, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bghgary bghgary marked this pull request as ready for review October 23, 2023 22:58
@bghgary bghgary requested a review from sebavan October 23, 2023 22:59
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 23, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 23, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14455/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 23, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14455/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bghgary
Copy link
Contributor Author

bghgary commented Oct 24, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 24, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14455/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 24, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14455/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan merged commit 54b8495 into BabylonJS:master Oct 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flipped faces in glTF export
4 participants