Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowDepthWrapper: Fix a memory leak when new effects must be created #14449

Merged
merged 10 commits into from Oct 20, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Oct 20, 2023

This is the PR #14406 by @nonlinearthink with a fix for the Webgl warnings (see #14406 (comment)).

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

@Popov72 Popov72 marked this pull request as draft October 20, 2023 18:47
@Popov72 Popov72 marked this pull request as ready for review October 20, 2023 19:47
@sebavan
Copy link
Member

sebavan commented Oct 20, 2023

Thanks a lot @nonlinearthink for finding the leak !!!

@sebavan sebavan merged commit 965d7f4 into BabylonJS:master Oct 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants