Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change script loading architecture #14447

Merged
merged 9 commits into from Oct 23, 2023
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 20, 2023

Scripts (js and wasm) should now be loaded using the Tools' GetScriptUrl function.

This function will check if the URL is absolute or relative. if relative it will append the BaseScriptUrl defined in Tools to the URL. Otherwise it will run a preprocessor and will make sure, if requested, that the URL is absolute.

This one you can either define a new URL per module OR a new global base URL for the scripts and thus replace the babylon's CDN in one call.

The preprocessor can be defined by the devs themselves to modify the URL to whatever it needs to be. Checking if the URL is absolute (GetAbsoluteUrl) was kept for back-compat reasons.

Notes

  • Tools.LoadScript will automatically use GetScriptUrl
  • It is possible to define a blob or data URL instead of a (relative) URL.
  • KTXDecoder has a different, simpler mechanism to change the base URL

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 20, 2023

packages/dev/core/src/Misc/tools.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Misc/tools.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Misc/tools.ts Outdated Show resolved Hide resolved
@bghgary
Copy link
Contributor

bghgary commented Oct 20, 2023

Should we change the tests code to use this feature or maybe a separate PR?

@RaananW
Copy link
Member Author

RaananW commented Oct 20, 2023

Should we change the tests code to use this feature or maybe a separate PR?

Good catch. I can add it here, will be a great test for the entire change.

@RaananW
Copy link
Member Author

RaananW commented Oct 20, 2023

I would wait on merging this till monday (even if approved) because... Friday?

@sebavan
Copy link
Member

sebavan commented Oct 20, 2023

I would wait on merging this till monday (even if approved) because... Friday?

I will probably merge and monitor as issues might not be too hard to fix and it looks like it might impact less ppl in case of regressions. What do you think ?

@sebavan sebavan merged commit 9341036 into BabylonJS:master Oct 23, 2023
10 checks passed
@RaananW RaananW deleted the overrideCDNUrls branch October 23, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants