Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font inheritance changes #14431

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Oct 17, 2023

Fix #13130

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2023

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the inheritance? Am I missing some function that hasn't changed?

@Popov72
Copy link
Contributor

Popov72 commented Oct 17, 2023

I'm not sure the visualization test can detect a problem, since it's based on a difference between the snapshot and the generated images. I think you should enlarge the text or add a lot more text to increase the chances of the visualization test detecting a problem.

@RaananW RaananW enabled auto-merge (squash) October 18, 2023 11:14
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 18, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14431/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 18, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14431/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit 84d7c29 into BabylonJS:master Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GE] Control font style inheritance
5 participants