Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and move to inline sourcemaps for dev #14411

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 11, 2023

Newer versions of VSCode seem to not follow the webpack-internal eval sourcemaps (like browsers are doing).
Apart from moving to inline sourcemaps i couldn't find a working solution.
There will be a slight change in compile time, but it is neglectable. Generated files (in development) will be larger, but memory consumption should be the same.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 11, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 11, 2023

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 11, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should factorize the common part of the config ?

@RaananW
Copy link
Member Author

RaananW commented Oct 11, 2023

already factorized TBH. webpackTools contains the default webpack configuration. This is a relic of older, quieter, more sane days.

I'll see what I can do

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 11, 2023

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 11, 2023

Reviewer - this PR has made changes to one or more package.json files.

@RaananW RaananW merged commit 377384e into BabylonJS:master Oct 11, 2023
10 checks passed
@RaananW RaananW deleted the fixVSCodeDebugging branch October 17, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants