-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies and move to inline sourcemaps for dev #14411
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14411/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14411/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14411/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should factorize the common part of the config ?
already factorized TBH. webpackTools contains the default webpack configuration. This is a relic of older, quieter, more sane days. I'll see what I can do |
Reviewer - this PR has made changes to one or more package.json files. |
Reviewer - this PR has made changes to one or more package.json files. |
Newer versions of VSCode seem to not follow the webpack-internal eval sourcemaps (like browsers are doing).
Apart from moving to inline sourcemaps i couldn't find a working solution.
There will be a slight change in compile time, but it is neglectable. Generated files (in development) will be larger, but memory consumption should be the same.