fix: correct the comment for resizeToFit #14363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the actual effect of
resizeToFit()
, I think it would be better to change the comment toto fit it's content
ratherto fit container
.The
TextBlock
will always be resized to fit it's content whether the text is too long or too large. Any excess beyond the container, like a plane attached the texture with oneTextBlock
, will not be displayed.In the meanwhile, when I set the
fontSize
,width
andresizeToFit
simultaneously, it'swidth
to fitfontSize
, ratherfontSize
to fitwidth
.It's all about the content. There's nothing about the
container
orto fit container
.As far as I'm concerned, the original version is kind of ambiguous to understand. And I think it might be better to make this modification for better clarity.
Thanks.