Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow graphs vector and matrix math #14357

Merged
merged 5 commits into from Sep 27, 2023
Merged

flow graphs vector and matrix math #14357

merged 5 commits into from Sep 27, 2023

Conversation

carolhmj
Copy link
Contributor

No description provided.

sebavan
sebavan requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the comments being similar, I let you check the full PR before doing a second pass.

packages/dev/core/src/FlowGraph/Blocks/Data/Math/flowGraphMatrixBlocks.ts Show resolved Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/Math/flowGraphMatrixBlocks.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/Math/flowGraphMatrixBlocks.ts Show resolved Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/Math/flowGraphMatrixBlocks.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/Math/flowGraphMatrixBlocks.ts Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2023

Snapshot stored with reference name:
refs/pull/14357/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14357/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14357/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14357/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14357/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14357/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14357/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14357/merge#BCU1XR#0

@sebavan sebavan merged commit 92aebb7 into BabylonJS:master Sep 27, 2023
10 checks passed
@carolhmj carolhmj deleted the vectorAndMatrixMath branch October 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
flow graph new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolhmj @bjsplat @sebavan