Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for recent Draco changes #14351

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Sep 25, 2023

See forum: https://forum.babylonjs.com/t/setting-the-value-0-to-the-defaultnumworkers-from-dracocompression-throw-an-engine-error-since-6-21-1-version/44323

  • Undo changes to vertex buffer so that engine is no longer nullable.
  • Factor out GetFloatData function so that it can be used in DracoCompression.
  • Update DracoCompression code to use VertexBuffer only when it's necessary.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

@bghgary bghgary marked this pull request as ready for review September 26, 2023 00:22
@bghgary bghgary merged commit bce27dc into BabylonJS:master Sep 26, 2023
10 checks passed
@bghgary bghgary deleted the draco-fix-2 branch September 26, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants