Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component if the label has changed #14346

Merged
merged 2 commits into from Sep 25, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Sep 25, 2023

The inspector doesn't update the labels under certain conditions.
This will refresh the component if the label has changed.

Influences the inspector.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14346/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan merged commit 159a9f2 into BabylonJS:master Sep 25, 2023
10 checks passed
@RaananW RaananW deleted the labelChangeFix branch September 26, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants