Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitwise blocks to Flow Graph #14334

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

carolhmj
Copy link
Contributor

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 21, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 21, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc is missing and same remark as before on the overall serialization and such. I wonder if you should add all the nodes before having put the full extend of what is needed per node ?

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seb commented - and there is a build issue.

@RaananW
Copy link
Member

RaananW commented Sep 22, 2023

Doc is missing and same remark as before on the overall serialization and such. I wonder if you should add all the nodes before having put the full extend of what is needed per node ?

We have discussed that offline - it will be implemented in 1-2 weeks.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2023

@RaananW RaananW merged commit 1d039a7 into BabylonJS:master Sep 25, 2023
10 checks passed
@carolhmj carolhmj deleted the flowGraphAddBitwiseBlocks branch October 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants